Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Dec 11 17:56:13 UTC 2018


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12259


Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments
......................................................................

trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

There is no need to (re)define the arguments of UDPLink's constructor.
Let's use non-keyworded variable length argument list (*args).

Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
---
M src/target/trx_toolkit/ctrl_if_bb.py
M src/target/trx_toolkit/ctrl_if_bts.py
2 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/12259/1

diff --git a/src/target/trx_toolkit/ctrl_if_bb.py b/src/target/trx_toolkit/ctrl_if_bb.py
index 785636b..fe7f3e8 100644
--- a/src/target/trx_toolkit/ctrl_if_bb.py
+++ b/src/target/trx_toolkit/ctrl_if_bb.py
@@ -34,8 +34,8 @@
 	tx_freq = None
 	pm = None
 
-	def __init__(self, remote_addr, remote_port, bind_addr, bind_port):
-		CTRLInterface.__init__(self, remote_addr, remote_port, bind_addr, bind_port)
+	def __init__(self, *udp_link_args):
+		CTRLInterface.__init__(self, *udp_link_args)
 		log.info("Init CTRL interface for BB (%s)" % self.desc_link())
 
 	def parse_cmd(self, request):
diff --git a/src/target/trx_toolkit/ctrl_if_bts.py b/src/target/trx_toolkit/ctrl_if_bts.py
index 2dde3e3..cb38b67 100644
--- a/src/target/trx_toolkit/ctrl_if_bts.py
+++ b/src/target/trx_toolkit/ctrl_if_bts.py
@@ -35,8 +35,8 @@
 	tx_freq = None
 	pm = None
 
-	def __init__(self, remote_addr, remote_port, bind_addr, bind_port):
-		CTRLInterface.__init__(self, remote_addr, remote_port, bind_addr, bind_port)
+	def __init__(self, *udp_link_args):
+		CTRLInterface.__init__(self, *udp_link_args)
 		log.info("Init CTRL interface for BTS (%s)" % self.desc_link())
 
 	def parse_cmd(self, request):

-- 
To view, visit https://gerrit.osmocom.org/12259
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a
Gerrit-Change-Number: 12259
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/e20c5cb7/attachment.htm>


More information about the gerrit-log mailing list