This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc ...................................................................... Patch Set 6: Code-Review-1 (3 comments) sorry, missed before: either not add the .err file, or if you want to add it (which would again be a separate patch though), then you also need to adjust libosmocore/tests/Makefile.am EXTRA_DIST to add it, and also adjust tests/testsuite.at so that the .err file gets validated. https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c File tests/gsm0408/gsm0408_test.c: https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@33 PS6, Line 33: #include <osmocom/core/logging.h> not needed https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@116 PS6, Line 116: printf(" is: %s\n", osmo_hexdump(msg->data, msg->len)); maybe a bit eager find-replace? I think this stderr output should also go to stdout, yes, but technically that's a separate patch. (This should never fire anyway as long as the test succeeds, that's why we never saw it.) https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@914 PS6, Line 914: }; drop this too -- To view, visit https://gerrit.osmocom.org/10185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia220764fba451be5e975ae7c5eefb1a25ac2bf2c Gerrit-Change-Number: 10185 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-CC: Holger Freyther <holger at freyther.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:58:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/05bc1de8/attachment.htm>