This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/7732 ) Change subject: trigger acc ramping based on trx rf-locked state ...................................................................... Patch Set 4: (4 comments) https://gerrit.osmocom.org/#/c/7732/1/src/libbsc/acc_ramp.c File src/libbsc/acc_ramp.c: https://gerrit.osmocom.org/#/c/7732/1/src/libbsc/acc_ramp.c@162 PS1, Line 162: > You are deferring an expected nm_statechg_signal_data pointer before knowing if that's the correct s […] Nice catch! Fixed in next patch set. https://gerrit.osmocom.org/#/c/7732/1/src/libbsc/acc_ramp.c@166 PS1, Line 166: acc_ramp_trigger(acc_ramp); > Is this really needed? we are only attaching the cb to the SS_NM subsystem right? […] Unsure. This was copied from bts_ipa_nm_sig_cb() in bts_ipaccess_nanobts.c. I didn't verify whether it's really required, and I'm happy to drop it (it certainly looks weird). https://gerrit.osmocom.org/#/c/7732/1/src/libbsc/acc_ramp.c@194 PS1, Line 194: acc_ramp->bts = bts; > What about NM_STATE_SHUTDOWN and NM_STATE_NULL? Would be nice at least adding an explicit case for N […] I'll make it abort ramping on SHUTDOWN as well. Not sure what to do about NULL -- for now I'd treat it as a no-op. An ASSERT on default would be a very bad idea because the administrative state value isn't checked by the lower layers but simply read verbatim from the TLV provided in the received packet. So an assert would introduce an easy way to kill the process remotely. I would rather log a warning instead (see next patch set). https://gerrit.osmocom.org/#/c/7732/1/src/libbsc/bsc_vty.c File src/libbsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/7732/1/src/libbsc/bsc_vty.c@3280 PS1, Line 3280: > You can take the chance to improve the "BTS reconnects" part by adding reference to RSL link. Yes this comment is a bit sparse. Improved in next patch set. -- To view, visit https://gerrit.osmocom.org/7732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4124f1da3dadec003de45c1da8435506ee8f0a34 Gerrit-Change-Number: 7732 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:57:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/914bf20d/attachment.htm>