This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/1089 ) Change subject: add 'make check' target ...................................................................... Patch Set 6: (1 comment) (posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx) https://gerrit.osmocom.org/#/c/1089/2/build/Makefile.asciidoc.inc File build/Makefile.asciidoc.inc: https://gerrit.osmocom.org/#/c/1089/2/build/Makefile.asciidoc.inc@40 PS2, Line 40: touch $@ > @grep -v WARNING $@ might already be enough.. and you used "" for touch.. […] grep -v would not print the WARNINGS, but I *want* the warnings in the output, hence the weird exit dance. I used touch so that the .check target is created even if the WARNING grep didn't produce any output. Ah you mean the quoting... hmm, remove these quotes or add them everywhere else? :) (These comments could go in-code.) -- To view, visit https://gerrit.osmocom.org/1089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibccc83a3415930a528f2e8e4e4dda3b81c6d0b64 Gerrit-Change-Number: 1089 Gerrit-PatchSet: 6 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:12:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/bb84d35e/attachment.htm>