This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/1707 ) Change subject: main: add VTY and '-c config-file' option ...................................................................... Patch Set 6: (1 comment) (posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx) https://gerrit.osmocom.org/#/c/1707/2/src/hlr_vty.c File src/hlr_vty.c: https://gerrit.osmocom.org/#/c/1707/2/src/hlr_vty.c@29 PS2, Line 29: int hlr_vty_is_config_node(struct vty *vty, int node) > Just skip it for the time being? And why the ENABLE_NODE? I have never understood the purpose of the ENABLE_NODE before, I thought it was something we just want to have in a VTY (for reasons that evade me). The HLR VTY is empty besides the logging commands, so indeed this function isn't any useful, more of a template for the future. This code is basically copied-and-stripped from openbsc, I wasn't paying too close attention... Right, now I notice that we can just omit this function. -- To view, visit https://gerrit.osmocom.org/1707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedb884345a597371a337b0c67eb6013b7d5d1ce1 Gerrit-Change-Number: 1707 Gerrit-PatchSet: 6 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:11:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/9a81f19a/attachment.htm>