This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/2484 ) Change subject: ofono_client: Implement network registration during connect() ...................................................................... Patch Set 1: (1 comment) (posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx) https://gerrit.osmocom.org/#/c/2484/1/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: https://gerrit.osmocom.org/#/c/2484/1/src/osmo_gsm_tester/ofono_client.py@225 PS1, Line 225: def connect(self, mcc=None, mnc=None): it would be nice here to have a choice: if I pass explicit MCC+MNC, then we ask the NetworkRegistration interface to do things. If not, just put the modem online and let it figure things out on its own. That way we could also merge the patch and have the current mo_mt_sms.py still use the automatic/implicit registration. Input validation: We need to make sure either both MCC and MNC are passed or neither. -- To view, visit https://gerrit.osmocom.org/2484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3092edc3dd76131da9aeeef6ad5082d1a9009342 Gerrit-Change-Number: 2484 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:10:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/410e8f3e/attachment.htm>