Change in libosmocore[master]: Add CC_CAUSE value_string array

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10732 )

Change subject: Add CC_CAUSE value_string array
......................................................................


Patch Set 2:

(1 comment)

(posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx)

https://gerrit.osmocom.org/#/c/10732/1/src/gsm/gsm48.c
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/#/c/10732/1/src/gsm/gsm48.c@950
PS1, Line 950: 	{ GSM48_CC_CAUSE_UNASSIGNED_NR,		"UNASSIGNED_NR" },
> very much so, yes. I was about to mkae that comment myself. […]
(I like it when FSM states and events have the same value string name as the constants in the code; if the names in log and code differ, it can get super hard to figure out what an FSM is doing / grep the events and states. That's why I added OSMO_VALUE_STRING(). For pretty much anything else, I agree to rather invent custom strings.)



-- 
To view, visit https://gerrit.osmocom.org/10732
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I296f208581ce2550805f9d96e20f7319e1199023
Gerrit-Change-Number: 10732
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:08:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/64424039/attachment.htm>