Change in osmo-msc[master]: drop gsm48 RR ciph mode compl from permitted initial messages

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12207 )

Change subject: drop gsm48 RR ciph mode compl from permitted initial messages
......................................................................

drop gsm48 RR ciph mode compl from permitted initial messages

It is a message that is initially permitted, but it is in fact not handled in
the L3 code but already before, upon receiving
BSS_MAP_MSG_CIPHER_MODE_COMPLETE.

Change-Id: I0079f07271ca76bd457d0e700f3a736eb9066b47
---
M src/libmsc/gsm_04_08.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Stefan Sperling: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 2962760..95c3183 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1296,7 +1296,8 @@
 		break;
 	case GSM48_PDISC_RR:
 		switch (msg_type) {
-		case GSM48_MT_RR_CIPH_M_COMPL:
+		/* GSM48_MT_RR_CIPH_M_COMPL is actually handled in bssmap_rx_ciph_compl() and gets redirected in the
+		 * BSSAP layer to ran_conn_cipher_mode_compl() (before this here is reached) */
 		case GSM48_MT_RR_PAG_RESP:
 			return true;
 		default:

-- 
To view, visit https://gerrit.osmocom.org/12207
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0079f07271ca76bd457d0e700f3a736eb9066b47
Gerrit-Change-Number: 12207
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/3514b03b/attachment.htm>