Change in osmo-sgsn[master]: Use libosmocore constant for IMSI length in ACL entry

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Dec 10 17:57:47 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12224 )

Change subject: Use libosmocore constant for IMSI length in ACL entry
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12224/2/include/osmocom/sgsn/gprs_sgsn.h
File include/osmocom/sgsn/gprs_sgsn.h:

https://gerrit.osmocom.org/#/c/12224/2/include/osmocom/sgsn/gprs_sgsn.h@417
PS2, Line 417: 	char imsi[GSM23003_IMSI_MAX_DIGITS + 2];
> > And in there we use +1, which makes more sense […]
So commit openbsc d3fa84dbba3b67cdbe2d8c789b2833b5ddf42068 changed GSM_IMSI_LENGTH to be GSM23003_IMSI_MAX_DIGITS+1 in all places except one to GSM23003_IMSI_MAX_DIGITS+2.

That looks like a typo in that commit to me. @Harald, can you confirm (you are the author of the commit)?



-- 
To view, visit https://gerrit.osmocom.org/12224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I138aea409aab0c748c75546e628797fc7498bf40
Gerrit-Change-Number: 12224
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Dec 2018 17:57:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181210/c8dea336/attachment.htm>


More information about the gerrit-log mailing list