Change in libosmocore[master]: gsm48_mi_to_string(): do not read from zero length input buffer

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12157 )

Change subject: gsm48_mi_to_string(): do not read from zero length input buffer
......................................................................

gsm48_mi_to_string(): do not read from zero length input buffer

Change-Id: I12cada7c2c5187146ca5a33d1ebfefb4cad65632
---
M src/gsm/gsm48.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index af3e14c..190622f 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -655,7 +655,7 @@
 	uint8_t mi_type;
 	uint32_t tmsi;
 
-	mi_type = mi[0] & GSM_MI_TYPE_MASK;
+	mi_type = (mi && mi_len) ? (mi[0] & GSM_MI_TYPE_MASK) : GSM_MI_TYPE_NONE;
 
 	switch (mi_type) {
 	case GSM_MI_TYPE_TMSI:

-- 
To view, visit https://gerrit.osmocom.org/12157
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I12cada7c2c5187146ca5a33d1ebfefb4cad65632
Gerrit-Change-Number: 12157
Gerrit-PatchSet: 9
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181210/f632d0b5/attachment.htm>