This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12228 )
Change subject: disable recording of LU timestamps by default
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/12228/2/src/db_hlr.c
File src/db_hlr.c:
https://gerrit.osmocom.org/#/c/12228/2/src/db_hlr.c@644
PS2, Line 644: if (osmo_clock_gettime(CLOCK_REALTIME, &localtime) != 0) {
Since starting from this line it seems to be a separate logic (updating VLR subscriber timestamp), I think it'd be clearer to have it in a separate function. Can be done in a follow-up patch. What do you think?
https://gerrit.osmocom.org/#/c/12228/2/src/hlr_vty.c
File src/hlr_vty.c:
https://gerrit.osmocom.org/#/c/12228/2/src/hlr_vty.c@133
PS2, Line 133: vty_out(vty, "Timestamps of Location Updates will be stored in the HLR database.%s", VTY_NEWLINE);
IMHO these vty_out lines can be dropped, but fine otherwise. We are storing subscriber data anyway, like "name", etc.
--
To view, visit https://gerrit.osmocom.org/12228
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f18b5ddc9b4b8e1174c6dea71cddf1c8d2230df
Gerrit-Change-Number: 12228
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Dec 2018 16:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181210/12669352/attachment.htm>