Change in libosmocore[master]: gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Dec 10 15:26:39 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12154 )

Change subject: gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12154/6/src/gsm/gsm48.c
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/#/c/12154/6/src/gsm/gsm48.c@642
PS6, Line 642:  * This function does not validate the Mobile Identity digits, i.e. digits > 9 are returned as 'A'-'F'.
May be worth having a test case for this scenario.



-- 
To view, visit https://gerrit.osmocom.org/12154
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
Gerrit-Change-Number: 12154
Gerrit-PatchSet: 6
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Mon, 10 Dec 2018 15:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181210/71b5d46c/attachment.htm>


More information about the gerrit-log mailing list