This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12125 ) Change subject: lms: Move {under,over}run checks into separate method ...................................................................... lms: Move {under,over}run checks into separate method Change-Id: I7f450aa79f6285d14826c40ecfdd9490d00509ef --- M Transceiver52M/device/lms/LMSDevice.cpp M Transceiver52M/device/lms/LMSDevice.h 2 files changed, 16 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp index 9804bbd..fa9e395 100644 --- a/Transceiver52M/device/lms/LMSDevice.cpp +++ b/Transceiver52M/device/lms/LMSDevice.cpp @@ -499,13 +499,26 @@ return GSM::Time(6,7); } +void LMSDevice::update_stream_stats(size_t chan, bool * underrun, bool * overrun) +{ + lms_stream_status_t status; + if (LMS_GetStreamStatus(&m_lms_stream_rx[chan], &status) == 0) { + if (status.underrun > m_last_rx_underruns[chan]) + *underrun = true; + m_last_rx_underruns[chan] = status.underrun; + + if (status.overrun > m_last_rx_overruns[chan]) + *overrun = true; + m_last_rx_overruns[chan] = status.overrun; + } +} + // NOTE: Assumes sequential reads int LMSDevice::readSamples(std::vector < short *>&bufs, int len, bool * overrun, TIMESTAMP timestamp, bool * underrun, unsigned *RSSI) { int rc = 0; unsigned int i; - lms_stream_status_t status; lms_stream_meta_t rx_metadata = {}; rx_metadata.flushPartialPacket = false; rx_metadata.waitForTimestamp = false; @@ -528,16 +541,7 @@ } if (timestamp != (TIMESTAMP)rx_metadata.timestamp) LOGC(DDEV, ALERT) << "chan "<< i << " recv buffer of len " << rc << " expect " << std::hex << timestamp << " got " << std::hex << (TIMESTAMP)rx_metadata.timestamp << " (" << std::hex << rx_metadata.timestamp <<") diff=" << rx_metadata.timestamp - timestamp; - - if (LMS_GetStreamStatus(&m_lms_stream_rx[i], &status) == 0) { - if (status.underrun > m_last_rx_underruns[i]) - *underrun = true; - m_last_rx_underruns[i] = status.underrun; - - if (status.overrun > m_last_rx_overruns[i]) - *overrun = true; - m_last_rx_overruns[i] = status.overrun; - } + update_stream_stats(i, underrun, overrun); thread_enable_cancel(true); } diff --git a/Transceiver52M/device/lms/LMSDevice.h b/Transceiver52M/device/lms/LMSDevice.h index d1a8813..fde2408 100644 --- a/Transceiver52M/device/lms/LMSDevice.h +++ b/Transceiver52M/device/lms/LMSDevice.h @@ -67,6 +67,7 @@ int get_ant_idx(const std::string & name, bool dir_tx, size_t chan); bool flush_recv(size_t num_pkts); + void update_stream_stats(size_t chan, bool * underrun, bool * overrun); public: -- To view, visit https://gerrit.osmocom.org/12125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7f450aa79f6285d14826c40ecfdd9490d00509ef Gerrit-Change-Number: 12125 Gerrit-PatchSet: 5 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181208/317cfa61/attachment.htm>