Change in osmocom-bb[master]: trx_toolkit: introduce logging configuration arguments

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri Dec 7 15:56:52 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12192 )

Change subject: trx_toolkit: introduce logging configuration arguments
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/12192/2/src/target/trx_toolkit/app_common.py
File src/target/trx_toolkit/app_common.py:

https://gerrit.osmocom.org/#/c/12192/2/src/target/trx_toolkit/app_common.py@50
PS2, Line 50: 		parser.add_argument("--log-lvl", metavar = "LVL",
I would suggest to name the option '--log-level'. The abbreviation to 'lvl' doesn't save that much typing.
Also, I would fine "LEVEL" easier to read than "LVL".

But this is just a matter of taste, and I won't mind if this remains as it is.


https://gerrit.osmocom.org/#/c/12192/2/src/target/trx_toolkit/app_common.py@61
PS2, Line 61: 		parser.add_argument("--log-file-lvl", metavar = "LVL",
Same here: I would suggest --log-file-level



-- 
To view, visit https://gerrit.osmocom.org/12192
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3b0440cd73946ad444bd7e48feb7a92d45f6488
Gerrit-Change-Number: 12192
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Fri, 07 Dec 2018 15:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181207/814eedf3/attachment.htm>


More information about the gerrit-log mailing list