Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Dec 6 18:14:06 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12177 )

Change subject: make gsup ipa name configurable in osmo-msc.cfg
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

we can drop the API compat stuff.

If you like also cut out the tests expectations stuff with a static ipa_dev -- even though my idea is slightly ugly (but then again we do keep a lot of global state anyway, and there will never be more than one gsm_network and vlr)

https://gerrit.osmocom.org/#/c/12177/2/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/12177/2/src/libmsc/gsm_04_08.c@1834
PS2, Line 1834: 	ipa_dev = talloc_zero(net->vlr, struct ipaccess_unit);
could use a static struct, then no talloc, and no changes in the test expectations?

though ... technically your patch this is nicer


https://gerrit.osmocom.org/#/c/12177/2/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/12177/2/src/libmsc/msc_vty.c@464
PS2, Line 464:       "Set the IPA name of this MSC (by default, no name is set)\n"
"This is transmitted as IPA Serial Number tag, which is used for GSUP routing (e.g. in OsmoHLR).
  For inter-MSC handover, the remote MSC's neighbor configuration requires to match this name.
  If no name is set, the IPA Serial Number will be the same as the Unit Name,
  and will be of the form 'MSC-00-00-00-00-00-00'."

Feel free to use any number of lines for a doc string (only end the last one in \n), vty will automatically format the output (I hope).

We can also add this text later...


https://gerrit.osmocom.org/#/c/12177/2/src/libvlr/vlr.c
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/#/c/12177/2/src/libvlr/vlr.c@1222
PS2, Line 1222: int vlr_start2(struct ipaccess_unit *ipa_dev, struct vlr_instance *vlr,
since we're inside osmo-msc and no-one is including libvlr except the msc itself, we can just change the function signature and not be backwards compatible.



-- 
To view, visit https://gerrit.osmocom.org/12177
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181206/ea44c995/attachment.htm>


More information about the gerrit-log mailing list