Change in libosmo-abis[master]: log IPA tags correctly

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Dec 6 16:40:39 UTC 2018


Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12175


Change subject: log IPA tags correctly
......................................................................

log IPA tags correctly

Due to apparent copy-paste errors, wrong values were being
logged for IPA tags in ipa_bts_id_resp().

Fixes: 4c57eef663e870247cb7a72130a50750317a44b9
Change-Id: I29a0401db0760219b9b9176709a88d589312261b
Related: OS#3355
---
M src/input/ipaccess.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/75/12175/1

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 8c02996..136aa79 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -603,15 +603,15 @@
 			break;
 		case IPAC_IDTAG_LOCATION1:
 			if (dev->location1)
-				osmo_strlcpy(str, dev->swversion, sizeof(str));
+				osmo_strlcpy(str, dev->location1, sizeof(str));
 			break;
 		case IPAC_IDTAG_LOCATION2:
 			if (dev->location2)
-				osmo_strlcpy(str, dev->swversion, sizeof(str));
+				osmo_strlcpy(str, dev->location2, sizeof(str));
 			break;
 		case IPAC_IDTAG_EQUIPVERS:
 			if (dev->equipvers)
-				osmo_strlcpy(str, dev->swversion, sizeof(str));
+				osmo_strlcpy(str, dev->equipvers, sizeof(str));
 			break;
 		case IPAC_IDTAG_SWVERSION:
 			if (dev->swversion)
@@ -627,7 +627,7 @@
 			break;
 		case IPAC_IDTAG_SERNR:
 			if (dev->serno)
-				osmo_strlcpy(str, dev->swversion, sizeof(str));
+				osmo_strlcpy(str, dev->serno, sizeof(str));
 			break;
 		default:
 			LOGP(DLINP, LOGL_NOTICE,

-- 
To view, visit https://gerrit.osmocom.org/12175
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29a0401db0760219b9b9176709a88d589312261b
Gerrit-Change-Number: 12175
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181206/ca1ef907/attachment.htm>


More information about the gerrit-log mailing list