Change in osmo-trx[master]: lms: Allow setting Tx/RxFreq for lchan!=0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Dec 5 19:43:47 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12097 )

Change subject: lms: Allow setting Tx/RxFreq for lchan!=0
......................................................................

lms: Allow setting Tx/RxFreq for lchan!=0

Related: OS#3346
Change-Id: I9dd0bb41d1863111d28947fc0d7c7e7ecfaf5fa8
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp
index 21bcece..8f3d8e1 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -601,12 +601,6 @@
 
 bool LMSDevice::setTxFreq(double wFreq, size_t chan)
 {
-
-	if (chan) {
-		LOGC(DDEV, ALERT) << "Invalid channel " << chan;
-		return false;
-	}
-
 	if (LMS_SetLOFrequency(m_lms_dev, LMS_CH_TX, chan, wFreq) < 0) {
 		LOGC(DDEV, ALERT) << "set Tx: " << wFreq << " failed!";
 		return false;
@@ -617,11 +611,6 @@
 
 bool LMSDevice::setRxFreq(double wFreq, size_t chan)
 {
-	if (chan) {
-		LOGC(DDEV, ALERT) << "Invalid channel " << chan;
-		return false;
-	}
-
 	if (LMS_SetLOFrequency(m_lms_dev, LMS_CH_RX, chan, wFreq) < 0) {
 		LOGC(DDEV, ALERT) << "set Rx: " << wFreq << " failed!";
 		return false;

-- 
To view, visit https://gerrit.osmocom.org/12097
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9dd0bb41d1863111d28947fc0d7c7e7ecfaf5fa8
Gerrit-Change-Number: 12097
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/432c6557/attachment.htm>


More information about the gerrit-log mailing list