Change in osmo-trx[master]: lms: Allow setting Tx/RxGain for chan!=0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Dec 5 19:43:47 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12096 )

Change subject: lms: Allow setting Tx/RxGain for chan!=0
......................................................................

lms: Allow setting Tx/RxGain for chan!=0

Related: OS#3346
Change-Id: I5fae92a7ed5e2d92be12b9dfd33fc56195030c0b
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 0 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp
index 712652a..21bcece 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -322,11 +322,6 @@
 
 double LMSDevice::setTxGain(double dB, size_t chan)
 {
-	if (chan) {
-		LOGC(DDEV, ALERT) << "Invalid channel " << chan;
-		return 0.0;
-	}
-
 	if (dB > maxTxGain())
 		dB = maxTxGain();
 	if (dB < minTxGain())
@@ -342,11 +337,6 @@
 
 double LMSDevice::setRxGain(double dB, size_t chan)
 {
-	if (chan) {
-		LOGC(DDEV, ALERT) << "Invalid channel " << chan;
-		return 0.0;
-	}
-
 	if (dB > maxRxGain())
 		dB = maxRxGain();
 	if (dB < minRxGain())

-- 
To view, visit https://gerrit.osmocom.org/12096
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fae92a7ed5e2d92be12b9dfd33fc56195030c0b
Gerrit-Change-Number: 12096
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/d1c60f34/attachment.htm>


More information about the gerrit-log mailing list