Change in python/osmo-python-tests[master]: twisted: disable low-level logging in dispatchers

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12150


Change subject: twisted: disable low-level logging in dispatchers
......................................................................

twisted: disable low-level logging in dispatchers

The same messages are better handled in derived classes using
message-specific functions instead of generic dispatchers.

Change-Id: I4a054eec9ef7ab39e15ac0cd64834a251d4fb2d7
---
M osmopy/twisted_ipa.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/50/12150/1

diff --git a/osmopy/twisted_ipa.py b/osmopy/twisted_ipa.py
index 70c1ef0..5b60d28 100755
--- a/osmopy/twisted_ipa.py
+++ b/osmopy/twisted_ipa.py
@@ -146,7 +146,7 @@
         """
         (_, proto, extension, content) = IPA().del_header(data)
         if content is not None:
-            self.dbg('IPA received %s::%s [%d/%d] %s' % (IPA().proto(proto), IPA().ext_name(proto, extension), len(data), len(content), content))
+            #self.dbg('IPA received %s::%s [%d/%d] %s' % (IPA().proto(proto), IPA().ext_name(proto, extension), len(data), len(content), content))
             method = getattr(self, 'handle_' + IPA().proto(proto), lambda: "protocol dispatch failure")
             method(content, proto, extension)
 
@@ -249,7 +249,7 @@
         OSMO CTRL message dispatcher, lambda default should never happen
         For basic tests only, appropriate handling routines should be replaced: see CtrlServer for example
         """
-        self.dbg('OSMO CTRL received %s::%s' % Ctrl().parse_kv(data))
+        #self.dbg('OSMO CTRL received %s::%s' % Ctrl().parse_kv(data))
         (cmd, op_id, v) = data.decode('utf-8').split(' ', 2)
         method = getattr(self, 'ctrl_' + cmd, lambda: "CTRL unknown command")
         method(data, op_id, v)

-- 
To view, visit https://gerrit.osmocom.org/12150
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a054eec9ef7ab39e15ac0cd64834a251d4fb2d7
Gerrit-Change-Number: 12150
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/a2e7cd81/attachment.htm>