Change in osmo-msc[master]: python tests: use py shebang instead of $(PYTHON)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Dec 5 14:20:19 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12138


Change subject: python tests: use py shebang instead of $(PYTHON)
......................................................................

python tests: use py shebang instead of $(PYTHON)

I'm going to make the external tests manually launchable. For that I first had
an error message if $(PYTHON) was empty. But Pau says I should just use shebang
instead and ignore the autoconf python stuff, since that often fails anyway.

Change-Id: Ie35dd78c42577109a6a3143221a9769e47d361a5
---
M tests/Makefile.am
M tests/ctrl_test_runner.py
M tests/smpp_test_runner.py
M tests/vty_test_runner.py
4 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/38/12138/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index c225afa..f6b33fc 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -46,10 +46,10 @@
 python-tests: $(BUILT_SOURCES)
 	osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v
 	osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v
-	$(PYTHON) $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v
-	$(PYTHON) $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v
+	$(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v
+	$(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v
 if BUILD_SMPP
-	$(PYTHON) $(srcdir)/smpp_test_runner.py -w $(abs_top_builddir) -v
+	$(srcdir)/smpp_test_runner.py -w $(abs_top_builddir) -v
 endif
 	rm -f $(top_builddir)/sms.db
 else
diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py
old mode 100644
new mode 100755
diff --git a/tests/smpp_test_runner.py b/tests/smpp_test_runner.py
old mode 100644
new mode 100755
diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py
old mode 100644
new mode 100755

-- 
To view, visit https://gerrit.osmocom.org/12138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie35dd78c42577109a6a3143221a9769e47d361a5
Gerrit-Change-Number: 12138
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/83494757/attachment.htm>


More information about the gerrit-log mailing list