Change in osmo-hlr[master]: introduce osmo_gsup_client_create2()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Dec 4 15:41:04 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12098 )

Change subject: introduce osmo_gsup_client_create2()
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/12098/2/src/gsupclient/gsup_client.c
File src/gsupclient/gsup_client.c:

https://gerrit.osmocom.org/#/c/12098/2/src/gsupclient/gsup_client.c@a178
PS2, Line 178: 
maybe rather keep this check? What happens if unit_name == NULL? Should we anyway force the caller to set one? I mean, there apparently was a reason for this, and the reason hasn't changed.


https://gerrit.osmocom.org/#/c/12098/2/src/gsupclient/gsup_client.c@260
PS2, Line 260:  * Create a gsup client connecting to the specified IP address and TCP port
Please use punctuation to end a sentence.
(I'm quite astonished at how often I need to say that recently.)

This project doesn't build doxygen, but if we use the format it might as well be correct.

Also end all \param in a '.'.

Also although I personally prefer '/**', osmocom has chosen to use '/*!' as doxygen indicator.



-- 
To view, visit https://gerrit.osmocom.org/12098
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief09677e07d6e977247185b72c605f109aa091f5
Gerrit-Change-Number: 12098
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Dec 2018 15:41:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181204/ca7d2241/attachment.htm>


More information about the gerrit-log mailing list