Change in osmo-ci[master]: gerrit-verifications/master-builds: with_manuals

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12045 )

Change subject: gerrit-verifications/master-builds: with_manuals
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml
File jobs/master-builds.yml:

https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml@206
PS2, Line 206:           cmd: GTP="$GTP" ./contrib/jenkins.sh --publish
Quick recap of what we discussed in private chat about this, as I was about to leave on Friday:
* you said, --publish is fine
* I'll change the environment variable to WITH_MANUALS, so it is uppercase as all environment variables should be.


> AFAIU the var is not redundant because it is not exported, so you'd need to either export GTP="$GTP" before calling jenkins.sh or, do it as it is done now.

I'm sure that it is redundant. See the osmo-trx section from master-builds.yml for example. Currently in master, we have this code:

      - osmo-trx:
          a1_name: INSTR
          # ARM variants temporarily disabled due to issue OS#3061
          # a1: !!python/tuple [--with-sse, --with-neon, --with-neon-vfpv4]
          a1: !!python/tuple [--with-sse]
          concurrent: true
          cmd: ./contrib/jenkins.sh --publish


So there's no INSTR="$INSTR" statement in front of jenkins.sh. The jenkins.sh script of osmo-trx.git has the following line:

  ./configure --enable-sanitize --enable-werror --with-uhd --with-usrp1 --with-lms $INSTR

And executed by jenkins, it it shows that INSTR holds --with-sse:

  + ./configure --enable-sanitize --enable-werror --with-uhd --with-usrp1 --with-lms --with-sse

https://jenkins.osmocom.org/jenkins/view/master/job/master-osmo-trx/710/INSTR=--with-sse,a2=default,a3=default,label=osmocom-master-debian9/console


> If that's not the case, then let's remove the GTP="$GTP" fomr verywhere

I'll post a patch for that.

> but I'd at least investigate git log why do wo do that.

The GTP="$GTP" line was introduced to master-builds.yml in the initial commit here:
https://gerrit.osmocom.org/#/c/osmo-ci/+/4827/

Seems to be copy-pasted from gerrit-verifications.yml at the time, where the line was introduced here:

https://gerrit.osmocom.org/#/c/osmo-ci/+/4826/1/jobs/gerrit-verifications.yml

No additional message explaining the purpose of GTP="$GTP" is in the commit message or review. Looks like it was just a misunderstanding.



-- 
To view, visit https://gerrit.osmocom.org/12045
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0643b17a6be6e86e281b50d78dd7a6858cf99ee
Gerrit-Change-Number: 12045
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Dec 2018 10:11:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181203/f8874140/attachment.htm>