Change in osmo-gsm-tester[master]: Generate imsi/ki on OsmoMobile construction

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Fri Aug 31 08:03:20 UTC 2018


Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/10682 )

Change subject: Generate imsi/ki on OsmoMobile construction
......................................................................

Generate imsi/ki on OsmoMobile construction

Take an IMSI/KI when creating the OsmoMobile and not when starting
it. This will allow other code to know which IMSIs will be used
before the system starts (e.g. to add it to the HLR/nitb db).

Change-Id: I79e259e948aa797c13118143ecd64bb7e29d274b
---
M src/osmo_ms_driver/starter.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ms_driver/starter.py b/src/osmo_ms_driver/starter.py
index 243dedc..bab468c 100644
--- a/src/osmo_ms_driver/starter.py
+++ b/src/osmo_ms_driver/starter.py
@@ -71,6 +71,7 @@
         self._imsi_ki_generator = imsi_ki_generator
         self._phy_filename = phy_filename
         self._ev_server_path = ev_server_path
+        self._imsi, self._ki = next(self._imsi_ki_generator)
 
     def write_lua_cfg(self):
         lua_support = os.path.join(os.path.dirname(__file__), 'lua')
@@ -87,13 +88,12 @@
         return lua_cfg_file
 
     def write_mob_cfg(self, lua_filename, phy_filename):
-        (imsi, ki) = next(self._imsi_ki_generator)
         cfg = {
             'test': {
                 'script': lua_filename,
                 'virt_phy': phy_filename,
-                'imsi': imsi,
-                'ki_comp128': ki,
+                'imsi': self._imsi,
+                'ki_comp128': self._ki,
                 'ms_number': self._name_number,
             }
         }

-- 
To view, visit https://gerrit.osmocom.org/10682
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I79e259e948aa797c13118143ecd64bb7e29d274b
Gerrit-Change-Number: 10682
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180831/781bc75d/attachment.htm>


More information about the gerrit-log mailing list