Change in osmo-ttcn3-hacks[master]: show return code when sending L1CTL_FBSB_REQ fails

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Aug 30 18:13:01 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10708 )

Change subject: show return code when sending L1CTL_FBSB_REQ fails
......................................................................

show return code when sending L1CTL_FBSB_REQ fails

Provide a little bit more information when a BTS test fails
due to L1CTL FBSB failure.

Example output:
Test case TC_si_sched_default finished. Verdict: fail reason: \
  FBSB Failed with non-zero return code 255

Change-Id: I5e8f23a2615b64bdf3167d486ba808c93f0f4b23
---
M library/L1CTL_PortType.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/library/L1CTL_PortType.ttcn b/library/L1CTL_PortType.ttcn
index 14a059c..8e03c02 100644
--- a/library/L1CTL_PortType.ttcn
+++ b/library/L1CTL_PortType.ttcn
@@ -35,12 +35,13 @@
 	function f_L1CTL_FBSB(L1CTL_PT pt, Arfcn arfcn, L1ctlCcchMode ccch_mode := CCCH_MODE_COMBINED, integer rxlev_exp := 57) {
 		timer T := 15.0;
 		for (var integer i := 0; i < 10; i := i+1) {
+			var L1ctlDlMessage dl;
 			pt.send(ts_L1CTL_FBSB_REQ(arfcn, valueof(t_L1CTL_FBSB_F_ALL), 0, ccch_mode, rxlev_exp));
 			T.start
 			alt {
 			[] pt.receive(tr_L1CTL_FBSB_CONF(0)) { return; };
-			[i >= 9] pt.receive(tr_L1CTL_FBSB_CONF(?)) {
-				setverdict(fail, "FBSB Failed with non-zero return code");
+			[i >= 9] pt.receive(tr_L1CTL_FBSB_CONF(?)) -> value dl {
+				setverdict(fail, "FBSB Failed with non-zero return code ", dl.payload.fbsb_conf.result);
 				mtc.stop;
 				};
 			[] pt.receive(tr_L1CTL_FBSB_CONF(?)) {

-- 
To view, visit https://gerrit.osmocom.org/10708
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e8f23a2615b64bdf3167d486ba808c93f0f4b23
Gerrit-Change-Number: 10708
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180830/03c9d55b/attachment.htm>


More information about the gerrit-log mailing list