Change in osmo-bsc[master]: cosmetic: lchan activ: no need to clear mr again

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Aug 30 15:13:59 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10699 )

Change subject: cosmetic: lchan activ: no need to clear mr again
......................................................................


Patch Set 1:

> This one does not actually make any funcitonal change. It is merely
 > removing two lines of code that have no effect anyway. For me
 > that's a cosmetic change?

They would have no effect if they were enclosed in comment tags or "#if 0", but they are not, so clearly you are changing the implementation and generated instructions. That would for instance require an increment in LIBVERSION revision:
"If the library source code has changed at all since the last update, then increment revision (‘c:r:a’ becomes ‘c:r+1:a’)."


-- 
To view, visit https://gerrit.osmocom.org/10699
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b38f222f1c8c822e8e5e776850dbc60e30e8b8d
Gerrit-Change-Number: 10699
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Aug 2018 15:13:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180830/1c175d33/attachment.htm>


More information about the gerrit-log mailing list