Change in osmo-sip-connector[master]: Use htonl, not ntohl before inet_ntoa()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Aug 29 07:39:18 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10646 )

Change subject: Use htonl, not ntohl before inet_ntoa()
......................................................................

Use htonl, not ntohl before inet_ntoa()

Change-Id: I805864759c287ad4e1d74e5f6ee16bf2d6a1b01f
---
M src/sdp.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Stefan Sperling: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/sdp.c b/src/sdp.c
index 213e979..17eb577 100644
--- a/src/sdp.c
+++ b/src/sdp.c
@@ -165,7 +165,7 @@
 
 char *sdp_create_file(struct sip_call_leg *leg, struct call_leg *other)
 {
-	struct in_addr net = { .s_addr = ntohl(other->ip) };
+	struct in_addr net = { .s_addr = htonl(other->ip) };
 	char *fmtp_str = NULL, *sdp;
 
 	leg->wanted_codec = app_media_name(other->payload_msg_type);

-- 
To view, visit https://gerrit.osmocom.org/10646
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I805864759c287ad4e1d74e5f6ee16bf2d6a1b01f
Gerrit-Change-Number: 10646
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180829/a9c99c83/attachment.htm>


More information about the gerrit-log mailing list