Change in libosmo-abis[master]: ipaccess: Allow passing return code in e1inp_line_ops->sign_link()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Aug 28 16:33:55 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10661


Change subject: ipaccess: Allow passing return code in e1inp_line_ops->sign_link()
......................................................................

ipaccess: Allow passing return code in e1inp_line_ops->sign_link()

Change-Id: Ia83eead3622d86f55c1dc5e91acc78dde73a0367
---
M include/osmocom/abis/e1_input.h
M src/input/ipaccess.c
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/61/10661/1

diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h
index 3fbce5b..79455e1 100644
--- a/include/osmocom/abis/e1_input.h
+++ b/include/osmocom/abis/e1_input.h
@@ -173,6 +173,7 @@
 
 	struct e1inp_sign_link *	(*sign_link_up)(void *unit_info, struct e1inp_line *line, enum e1inp_sign_type type);
 	void	(*sign_link_down)(struct e1inp_line *line);
+	/* Called when a new message arrives. -EBADF must be returned if the osmo_fd in link (msg->dst) is destroyed. */
 	int	(*sign_link)(struct msgb *msg);
 };
 
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 24a79ea..566fd64 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -279,7 +279,7 @@
 		     " sign_link returned error: %s.\n", strerror(-rc));
 	}
 
-	return 0;
+	return rc;
 err_msg:
 	msgb_free(msg);
 err:
@@ -790,8 +790,7 @@
 			"no action set for signalling messages.\n");
 		goto err;
 	}
-	link->line->ops->sign_link(msg);
-	return 0;
+	return link->line->ops->sign_link(msg);
 
 err:
 	ipa_client_conn_close(link);

-- 
To view, visit https://gerrit.osmocom.org/10661
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia83eead3622d86f55c1dc5e91acc78dde73a0367
Gerrit-Change-Number: 10661
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180828/c43a4a7b/attachment.htm>


More information about the gerrit-log mailing list