This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/9257 ) Change subject: gprs_gmm: introduce a GMM Attach Request FSM ...................................................................... Patch Set 12: Code-Review-1 (3 comments) missing UMTS_RESYNC https://gerrit.osmocom.org/#/c/9257/1/src/gprs/gprs_gmm_attach.c File src/gprs/gprs_gmm_attach.c: https://gerrit.osmocom.org/#/c/9257/1/src/gprs/gprs_gmm_attach.c@143 PS1, Line 143: /* network failure */ > this appears that UMTS AKA is not working with this new FSM? Was it also broken before this FSM? I […] I talked to neels about this. I'll implemented this. https://gerrit.osmocom.org/#/c/9257/1/src/gprs/gprs_gmm_attach.c@155 PS1, Line 155: struct sgsn_mm_ctx *ctx = fi->priv; > do we want to silently ignore any other events? In other FSMs we explicitly OSMO_ASSERT() on any un […] It's possible to get other events in case of packet lost. If we get a doublicated event, we can ignore it, because the timeout will resent the packet anyway. https://gerrit.osmocom.org/#/c/9257/1/src/gprs/gprs_gmm_attach.c@175 PS1, Line 175: { > does this mean you're not supporting disabling or enabling of P-TMSI allocation? I believe it shoul […] It's working in the same way, if PTMSI_ALLOC is defined. I haven't implement the other leg, because the code looked weired and I expected it wasn't used anymore. -- To view, visit https://gerrit.osmocom.org/9257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58b9c17be9776a03bb2a5b21e99135cfefc8c912 Gerrit-Change-Number: 9257 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Tue, 28 Aug 2018 13:54:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180828/717cd31a/attachment.htm>