This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10645 ) Change subject: fix unaligned access in abis_nm_rx_ipacc() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/10645/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/10645/1/src/osmo-bsc/abis_nm.c@2667 PS1, Line 2667: memcpy(&port, TLVP_VAL(&tp, NM_ATT_IPACC_DST_IP_PORT), sizeof(port)); I think we've had this exact example in reviews during past weeks several times now. We do have osmo_load16be() for this purpose. Thanks :) -- To view, visit https://gerrit.osmocom.org/10645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9bdce39472719bfebec29e0a55a021ef45c8ea6 Gerrit-Change-Number: 10645 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Tue, 28 Aug 2018 10:56:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180828/9347bf50/attachment.htm>