Change in libosmocore[master]: gsmtap_util: make sure SO_REUSEADDR is applied for GSMTAP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Aug 23 18:44:00 UTC 2018


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10588


Change subject: gsmtap_util: make sure SO_REUSEADDR is applied for GSMTAP
......................................................................

gsmtap_util: make sure SO_REUSEADDR is applied for GSMTAP

When gsmtap adding a new sink it does not supply OSMO_SOCK_F_UDP_REUSEADDR
in order to have SO_REUSEADDR applied. Even when the gsmtap sink is just
receiving packets to toss them immediately, its technically a multicast
application. This is because every application that outputs gsmtap also
adds its own sink. Therefore SO_REUSEADDR must be applied.

Change-Id: I1399a428467ca12f1564a14eb8ffb294d4f59874
Related: OS#3497
---
M src/gsmtap_util.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/10588/1

diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c
index b21c690..385b467 100644
--- a/src/gsmtap_util.c
+++ b/src/gsmtap_util.c
@@ -254,7 +254,9 @@
 
 	if (osmo_sockaddr_is_local((struct sockaddr *)&ss, ss_len) == 1) {
 		rc = osmo_sock_init_sa((struct sockaddr *)&ss, SOCK_DGRAM,
-					IPPROTO_UDP, OSMO_SOCK_F_BIND);
+				       IPPROTO_UDP,
+				       OSMO_SOCK_F_BIND |
+				       OSMO_SOCK_F_UDP_REUSEADDR);
 		if (rc >= 0)
 			return rc;
 	}

-- 
To view, visit https://gerrit.osmocom.org/10588
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1399a428467ca12f1564a14eb8ffb294d4f59874
Gerrit-Change-Number: 10588
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180823/bc79d49f/attachment.htm>


More information about the gerrit-log mailing list