Change in pysim[master]: cards: do not feed ascii as adm for sysmosim-gr1

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10571 )

Change subject: cards: do not feed ascii as adm for sysmosim-gr1
......................................................................

cards: do not feed ascii as adm for sysmosim-gr1

When sysmosom-gr1 is used with a custom ADM key, then the ADM string is
not fed through h2b() like we see it with sysmo-usim-sjs1 for example.

- feed the ADM to h2b() before use

Change-Id: I0b7cab380b89612ed3b8318e014161038335fe1b
Related: OS#3405
---
M pySim/cards.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/pySim/cards.py b/pySim/cards.py
index 4dee0d8..e294f9a 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -338,7 +338,7 @@
 
 		# Authenticate using ADM PIN 5
 		if p['pin_adm']:
-			pin = p['pin_adm']
+			pin = h2b(p['pin_adm'])
 		else:
 			pin = h2b("4444444444444444")
 		self._scc.verify_chv(5, pin)

-- 
To view, visit https://gerrit.osmocom.org/10571
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b7cab380b89612ed3b8318e014161038335fe1b
Gerrit-Change-Number: 10571
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180823/62f6ad69/attachment.htm>