This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10492 ) Change subject: measurement: make sure measurement interval end is detected ...................................................................... Patch Set 2: Code-Review+2 (3 comments) looks good to me, thanks for your changes! https://gerrit.osmocom.org/#/c/10492/1/include/osmo-bts/gsm_data_shared.h File include/osmo-bts/gsm_data_shared.h: https://gerrit.osmocom.org/#/c/10492/1/include/osmo-bts/gsm_data_shared.h@263 PS1, Line 263: measurement > measurement Done https://gerrit.osmocom.org/#/c/10492/1/include/osmo-bts/gsm_data_shared.h@264 PS1, Line 264: last_fn > I can see you are writing to this field, but I cannot see that you ever reset/reinitialize it after […] Done https://gerrit.osmocom.org/#/c/10492/1/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/#/c/10492/1/src/common/measurement.c@280 PS1, Line 280: ak; > what about the start condition? lchan->meas. […] Done -- To view, visit https://gerrit.osmocom.org/10492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a86cd8185cc6b94258373fe929f0c2f1cf27cfa Gerrit-Change-Number: 10492 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Mon, 20 Aug 2018 20:27:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180820/b59e72a9/attachment.htm>