Change in osmo-sip-connector[master]: Logging: in check_rtp_create() log the IP address in human readable d...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Aug 17 16:07:19 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10490 )

Change subject: Logging: in check_rtp_create() log the IP address in human readable dotted quad format.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10490/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/10490/1/src/mncc.c@386
PS1, Line 386: inet_ntoa(net)
inet_ntoa is specified as being used with ip addresses in *network byte order*.  Above you appear to be converting it from netowrk to host byte order (ntohl)?



-- 
To view, visit https://gerrit.osmocom.org/10490
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I298b13836cc6b9c5888f931deca61132d31da035
Gerrit-Change-Number: 10490
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 16:07:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180817/9f1b6f34/attachment.htm>


More information about the gerrit-log mailing list