Change in osmocom-bb[master]: trxcon: suppress WARNING log message on NEIGH_PM_REQ

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Aug 11 12:05:37 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10432 )

Change subject: trxcon: suppress WARNING log message on NEIGH_PM_REQ
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/10432/1/src/host/trxcon/l1ctl.c
File src/host/trxcon/l1ctl.c:

https://gerrit.osmocom.org/#/c/10432/1/src/host/trxcon/l1ctl.c@796
PS1, Line 796: 	case L1CTL_NEIGH_PM_REQ:
I think it makes much more sense to define _L1CTL_MAX, and
check if a message is within the range or not, instead of
adding such warnings for each (yet) unsupported message...



-- 
To view, visit https://gerrit.osmocom.org/10432
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id76993056fb514e6fb0242d505205316c61bb965
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 11 Aug 2018 12:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180811/4c8664f0/attachment.htm>


More information about the gerrit-log mailing list