Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_gmm_attach_req_while_gmm_attach

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Aug 9 11:13:51 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10392 )

Change subject: sgsn: add TC_attach_gmm_attach_req_while_gmm_attach
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10392/1/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/#/c/10392/1/sgsn/SGSN_Tests.ttcn@1944
PS1, Line 1944: 	}
do you have a 'default activated altstep somewhere?  I'm asking as I don't see any "catch-all" clause here that would e.g. catch any other L3 PDU received from the SGSN.  In such situations, we would block until the guard timer times out and fail with a very nondescript error message.

As default-activated altsteps are somewhat un-obvious, an explicit altstep invocation like might be the best option. Avoids copying code around, while still making it explicit which alternatives exist in an alt{}

[] as_any_other_l3();



-- 
To view, visit https://gerrit.osmocom.org/10392
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bac50dc5a72ba8f9010b05bcb98aa7ff0b81cf6
Gerrit-Change-Number: 10392
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 09 Aug 2018 11:13:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180809/b99accad/attachment.htm>


More information about the gerrit-log mailing list