This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10372 ) Change subject: add DTX fill frame BTS tests ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/10372/2/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/10372/2/bts/BTS_Tests.ttcn@3855 PS2, Line 3855: 2.5 how do you get to this 2.5 seconds? IMHO, 104*4.6ms = 478ms. So The 104 frames should expire in half a second. Your tests wait five times that amount, so if 80% of the frames were lost, it would still pass? I think rather than relying on wall clock / system time of the test host, it would be best to count in terms of frame numbers received from L1. This means that from a given start frame number, start receiving until fn+104 is received as frame number, and then count over that interval. The host-side timeout is merely a guard timer, and it can be 2.5,5,10 or whatever amount of times long. https://gerrit.osmocom.org/#/c/10372/2/bts/BTS_Tests.ttcn@3866 PS2, Line 3866: t_RslChanNr_Bm(1) I would structure the test in a way that it iterates over all the TCH/F we have. There are subtle differences in how individual timeslots are handled, so it makes sense to iterater over all of them. I think some of our other tests already do this. -- To view, visit https://gerrit.osmocom.org/10372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4e0de6e78b62cd408f600a57a28617d91da64af Gerrit-Change-Number: 10372 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 16:47:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180807/09023a9e/attachment.htm>