Change in libosmocore[master]: vty/vty.c: fix bug in vty_config_write

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Mykola Shchetinin gerrit-no-reply at lists.osmocom.org
Fri Aug 3 13:54:54 UTC 2018


Mykola Shchetinin has uploaded this change for review. ( https://gerrit.osmocom.org/10332


Change subject: vty/vty.c: fix bug in vty_config_write
......................................................................

vty/vty.c: fix bug in vty_config_write

the vty_config_write function should write:
line vty
 login
to the configuration file when the login is enabled. Otherwise after
saving the configuration the next login will be performed without
password checking (password_check variable will be 0 though it must be 1)

Change-Id: I39050b6bf617dac10d3fccc3106f67bdcca1d05a
---
M src/vty/vty.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/10332/1

diff --git a/src/vty/vty.c b/src/vty/vty.c
index aab0607..ad53537 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -1694,6 +1694,8 @@
 	/* login */
 	if (!password_check)
 		vty_out(vty, " no login%s", VTY_NEWLINE);
+	else
+		vty_out(vty, " login%s", VTY_NEWLINE);
 
 	/* bind */
 	if (vty_bind_addr && (strcmp(vty_bind_addr, VTY_BIND_ADDR_DEFAULT) != 0))

-- 
To view, visit https://gerrit.osmocom.org/10332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39050b6bf617dac10d3fccc3106f67bdcca1d05a
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 1
Gerrit-Owner: Mykola Shchetinin <mykola at razormaker.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180803/455ea22c/attachment.htm>


More information about the gerrit-log mailing list