Change in osmo-mgw[master]: network: do not patch PT of RTCP packets

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10329


Change subject: network: do not patch PT of RTCP packets
......................................................................

network: do not patch PT of RTCP packets

At the moment all packets that are sent with mgcp_send are fed into
mgcp_patch_pt(). This functions corrects the payload type so that it
matches the codec configuration on the egress side. However, this
functions is only to be used with RTP packets and must not be used on
RTCP packets, which we currently do because we do not check if the
packet is RTCP or RTP.

- Check if the packet is RTP before running mgcp_patch_pt()

Change-Id: I55b8aa830e4e23f991373470bd04d4db12241c56
Related: OS#3444
---
M src/libosmo-mgcp/mgcp_network.c
1 file changed, 7 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/29/10329/1

diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c
index 1b1867a..6dfc5a5 100644
--- a/src/libosmo-mgcp/mgcp_network.c
+++ b/src/libosmo-mgcp/mgcp_network.c
@@ -717,11 +717,13 @@
 	 * course unable to patch the payload type. A situation like this
 	 * should not occur if transcoding is consequently avoided. Until
 	 * we have transcoding support in osmo-mgw we can not resolve this. */
-	rc = mgcp_patch_pt(conn_src, conn_dst, buf, len);
-	if (rc < 0) {
-		LOGP(DRTP, LOGL_ERROR,
-		     "endpoint:0x%x can not patch PT because no suitable egress codec was found.\n",
-		     ENDPOINT_NUMBER(endp));
+	if (is_rtp) {
+		rc = mgcp_patch_pt(conn_src, conn_dst, buf, len);
+		if (rc < 0) {
+			LOGP(DRTP, LOGL_ERROR,
+			     "endpoint:0x%x can not patch PT because no suitable egress codec was found.\n",
+			     ENDPOINT_NUMBER(endp));
+		}
 	}
 
 	/* Note: In case of loopback configuration, both, the source and the

-- 
To view, visit https://gerrit.osmocom.org/10329
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55b8aa830e4e23f991373470bd04d4db12241c56
Gerrit-Change-Number: 10329
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180803/af6f4451/attachment.htm>