Change in osmo-ttcn3-hacks[master]: mgw: Don't try to send packets while MDCX is underway

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Aug 1 19:27:44 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10302 )

Change subject: mgw: Don't try to send packets while MDCX is underway
......................................................................

mgw: Don't try to send packets while MDCX is underway

TC_two_crcx_and_one_mdcx_rtp_ho sometimes failed while trying to send an
RTP packet without a connected port. f_flow_modify re-bind()s the port,
sends the MDCX and then connect()s it after the MDCX ACK returned the
IP/port combination.
If the transmit timer fires off between the bind and connect the
resulting send call will fail.

Change-Id: Idf93ceb830a44dafa56430ab5178f05da6bdd6fb
---
M mgw/MGCP_Test.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 494e8bb..e1ebc26 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -1258,7 +1258,9 @@
 		/* Now switch the flow over to a new port (BTS) */
 		port_old := flow[0].em.portnr;
 		flow[0].em.portnr := 10002;
+		f_rtpem_mode(RTPEM[0], RTPEM_MODE_RXONLY);
 		f_flow_modify(RTPEM[0], ep, call_id, "sendrecv", flow[0]);
+		f_rtpem_mode(RTPEM[0], RTPEM_MODE_BIDIR);
 
 		/* When handing over a call, the old source may still keep
 		 * transmitting for a while. We simulate this by injecting

-- 
To view, visit https://gerrit.osmocom.org/10302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf93ceb830a44dafa56430ab5178f05da6bdd6fb
Gerrit-Change-Number: 10302
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180801/2342f134/attachment.htm>


More information about the gerrit-log mailing list