[PATCH] osmo-sgsn[master]: log two RA Update Request failure causes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Apr 30 23:36:20 UTC 2018


Review at  https://gerrit.osmocom.org/7958

log two RA Update Request failure causes

Change-Id: Ic9c8a492abf5a707b37d9c8888c59be6e51541b8
---
M src/gprs/gprs_gmm.c
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/58/7958/1

diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index 275cdbc..642c738 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -1616,6 +1616,9 @@
 	/* MS Radio Access Capability 10.5.5.12a */
 	ms_ra_acc_cap_len = *cur++;
 	if (ms_ra_acc_cap_len > 52) {
+		LOGP(DMM, LOGL_ERROR,
+		     "Rejecting GMM RA Update Request: MS Radio Access Capability too long"
+		     " (ms_ra_acc_cap_len = %u > 52)\n", ms_ra_acc_cap_len);
 		reject_cause = GMM_CAUSE_PROTO_ERR_UNSPEC;
 		goto rejected;
 	}
@@ -1668,6 +1671,7 @@
 				mmctx = sgsn_mm_ctx_by_ptmsi(tmsi);
 			}
 #else
+			LOGP(DMM, LOGL_ERROR, "Rejecting GMM RA Update Request: No Iu support\n");
 			goto rejected;
 #endif
 		}
@@ -1704,6 +1708,7 @@
 		/* The MS has to perform GPRS attach */
 		/* Device is still IMSI attached for CS but initiate GPRS ATTACH,
 		 * see GSM 04.08, 4.7.5.1.4 and G.6 */
+		LOGMMCTXP(LOGL_ERROR, mmctx, "Rejecting GMM RA Update Request: MS should GMM Attach first\n");
 		reject_cause = GMM_CAUSE_IMPL_DETACHED;
 		goto rejected;
 	}

-- 
To view, visit https://gerrit.osmocom.org/7958
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9c8a492abf5a707b37d9c8888c59be6e51541b8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list