[MERGED] libosmo-netif[master]: osmux: Fix use of uninitialized memory in osmux_out_handle

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmux: Fix use of uninitialized memory in osmux_out_handle
......................................................................


osmux: Fix use of uninitialized memory in osmux_out_handle

In Change-Id: I2efed6d726a1b8e77e686c7a5fe1940d3f4901a7 we're adding a
new member to 'struct osmux_out_handle' which is not initialized.

Rather than initializing this single new member, let's do a memset()
over the entire osmux_out_handle at the beginnign of
osmux_xfrm_output_init().

Change-Id: I751e9414c6de2413a9f977e5ae5655ebfd114f45
Closes: OS#3219
---
M src/osmux.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmux.c b/src/osmux.c
index 872588d..46170ba 100644
--- a/src/osmux.c
+++ b/src/osmux.c
@@ -1001,6 +1001,7 @@
 
 void osmux_xfrm_output_init(struct osmux_out_handle *h, uint32_t rtp_ssrc)
 {
+	memset(h, 0, sizeof(*h));
 	h->rtp_seq = (uint16_t)random();
 	h->rtp_timestamp = (uint32_t)random();
 	h->rtp_ssrc = rtp_ssrc;

-- 
To view, visit https://gerrit.osmocom.org/7948
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I751e9414c6de2413a9f977e5ae5655ebfd114f45
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder