[PATCH] osmo-ttcn3-hacks[master]: ggsn: Disable GTP-U tx sequence number by default

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 26 08:45:20 UTC 2018


Review at  https://gerrit.osmocom.org/7935

ggsn: Disable GTP-U tx sequence number by default

GTP-U transmit sequence numbers are entirely optional and probably
don't serve any real purpose in real-world deployments.

While OsmoGGSN in userspace implements support for it, the kernel GTP-U
implementation doesn't.  This means a number of tests fail against
kernel GTP-U only for that reason.

Let's switch all tests to disable GTP-U sequence numbers, and only
enable it in one specific test.  This way, we can execute the tests
also against kernel GTP-U.

Related: OS#3215
Change-Id: I666f5276749ef6a1a4dc170a3b9a747f626f6b2c
---
M ggsn_tests/GGSN_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/7935/1

diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index cb6aabf..d099681 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -93,7 +93,7 @@
 		var uint16_t g_d_seq_nr;
 
 		port TELNETasp_PT GGSNVTY;
-		var boolean use_gtpu_txseq := true;
+		var boolean use_gtpu_txseq := false;
 	}
 
 	private function f_init_vty() runs on GT_CT {

-- 
To view, visit https://gerrit.osmocom.org/7935
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I666f5276749ef6a1a4dc170a3b9a747f626f6b2c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list