This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 5: Code-Review-1 (5 comments) sorry to -1 again, but... https://gerrit.osmocom.org/#/c/7743/5/src/hlr.c File src/hlr.c: Line 78: "IMSI='%s': Cannot notify GSUP client, cannot get peer name " still unaddressed: double space in string Line 101: len = osmo_apn_from_str(apn, sizeof(apn), "*"); I still think these bits could be in a common function used by luop and this function, to avoid code dup from the start. Line 111: gsup.cn_domain = OSMO_GSUP_CN_DOMAIN_CS; unaddressed comment: if neither CS nor PS has been seen, skip this item, since we then don't have any LU ops and no subscribers that need updating. Line 117: "IMSI='%s': Cannot notify GSUP client; could not allocate msg buffer " double space Line 127: "IMSI='%s': Cannot notify GSUP client; send operation failed " double space -- To view, visit https://gerrit.osmocom.org/7743 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c43ece2b48dc63d599000eb6d6d51e08963067 Gerrit-PatchSet: 5 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes