[MERGED] osmo-msc[master]: setup_trig_pag_evt: Remove uneeded default case in switch st...

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: setup_trig_pag_evt: Remove uneeded default case in switch statement
......................................................................


setup_trig_pag_evt: Remove uneeded default case in switch statement

Take the chance to  pass a var of type enum instead, so the compiler
warns us if a new enum value is added. For instance, if we remove
GSM_PAGING_EXPIRED from the switch statement:

src/libmsc/gsm_04_08.c:1463:2: warning: enumeration value ‘GSM_PAGING_EXPIRED’ not handled in switch [-Wswitch]
  switch (paging_event) {
  ^~~~~~

Change-Id: I65d871704b9636c594dc982200fbe7f7ce6784f5
---
M src/libmsc/gsm_04_08.c
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 2b8e4c1..ea5a81a 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1456,10 +1456,11 @@
 {
 	struct gsm_subscriber_connection *conn = _conn;
 	struct gsm_trans *transt = _transt;
+	enum gsm_paging_event paging_event = event;
 
 	OSMO_ASSERT(!transt->conn);
 
-	switch (event) {
+	switch (paging_event) {
 	case GSM_PAGING_SUCCEEDED:
 		DEBUGP(DCC, "Paging subscr %s succeeded!\n",
 		       vlr_subscr_msisdn_or_name(transt->vsub));
@@ -1481,9 +1482,6 @@
 		transt->callref = 0;
 		transt->paging_request = NULL;
 		trans_free(transt);
-		break;
-	default:
-		LOGP(DCC, LOGL_ERROR, "Unknown paging event %d\n", event);
 		break;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/7901
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65d871704b9636c594dc982200fbe7f7ce6784f5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>