This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (5 comments) could you explain/formalize the flow of messages around session management; something like: GSUP client requests a session ID with message X, server returns an unused one with msg Y, server remembers active IDs until client sends <what> or client disconnects... It should go in osmo-gsm-manuals/common/chapters/gsup.adoc in a patch next to this one, so that we can approve the design as a whole. https://gerrit.osmocom.org/#/c/7700/1/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: Line 88: * SESSION_ID is used to distinguish between concurrent rather place individual doxygen comments at each enum val, with /*! ... */ before, or with /*< ... */ after the item. Then again, reading the comment, an ID is always used to distinguish between concurrent foos and is unique. Line 92: * see the 'osmo_gsup_session_state' enum for details. I'd reduce this to /*< see also enum osmo_gsup_session_state */ Line 160: /* Undefined session state */ doxygen https://gerrit.osmocom.org/#/c/7700/1/src/gsm/gsup.c File src/gsm/gsup.c: Line 585: msgb_tlv_put(msg, OSMO_GSUP_SESSION_STATE_IE, sizeof(u8), &u8); sizeof(u8)? :) ... interesting, also found above. It's 1 of course, but ok, leave it in then. https://gerrit.osmocom.org/#/c/7700/1/tests/gsup/gsup_test.c File tests/gsup/gsup_test.c: Line 186: }; OSMO_GSUP_MSGT_SESSION_ID_ERROR ? -- To view, visit https://gerrit.osmocom.org/7700 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cee271fed0284a134ffed103c0d4bebbcfde2a8 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes