libosmocore[master]: osmo_get_macaddr: Fix buffer read out of bounds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Apr 17 16:08:00 UTC 2018


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/7863/1/src/macaddr.c
File src/macaddr.c:

Line 137: 	memcpy(&ifr.ifr_name, dev_name, dev_len);
osmo_strlcpy() with sizeof() would ensure nul termination in all cases? but then again you return -EINVAL if it doesn't fit, which is probably a good thing.


-- 
To view, visit https://gerrit.osmocom.org/7863
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3727ef339279c8eeb85908735467bfd0e02ca259
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list