[PATCH] osmo-ttcn3-hacks[master]: RSL_Emulation: Less verbose logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Apr 15 14:25:53 UTC 2018


Review at  https://gerrit.osmocom.org/7809

RSL_Emulation: Less verbose logging

Don't use explicit log() statements for normal message forwarding
between ports.  This will be visible in the automatically-generated log
statements anyway...

Change-Id: Idcfb1897dd00df1839cf1a0182a5a030bf71c0cb
---
M library/RSL_Emulation.ttcn
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/7809/1

diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index b743d60..3ad062b 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -354,7 +354,6 @@
 			var GsmRrMessage rr;
 			var OCT1 ra;
 			var GsmFrameNumber fn;
-			log("IMM ASS INFO ", rx_rsl.rsl.ies[1].body);
 			rr := dec_GsmRrMessage(rx_rsl.rsl.ies[1].body.full_imm_ass_info.payload);
 			if (ischosen(rr.payload.imm_ass)) {
 				ra := bit2oct(rr.payload.imm_ass.req_ref.ra);
@@ -389,7 +388,6 @@
 		}
 
 		[bts_role] IPA_PT.receive(tr_RSL(tr_RSL_PAGING_CMD(?, ?))) -> value rx_rsl {
-			log("PAGING IDENTITY ", rx_rsl.rsl.ies[2].body.other);
 			/* broadcast to all clients? */
 			for (i := 0; i < sizeof(ConnectionTable); i := i + 1) {
 				if (ispresent(ConnectionTable[i].comp_ref)) {
@@ -400,13 +398,11 @@
 
 		/* Forward common channel management to the special port for it */
 		[] IPA_PT.receive(tr_RSL(tr_RSL_MsgTypeT(?))) -> value rx_rsl {
-			log("Forwarding TRX Mgmt ", rx_rsl.rsl);
 			CCHAN_PT.send(rx_rsl);
 		}
 
 		/* Forward common channel management to the special port for it */
 		[] IPA_PT.receive(tr_RSL(tr_RSL_MsgTypeC(?))) -> value rx_rsl {
-			log("Forwarding Common Channel Mgmt ", rx_rsl.rsl);
 			CCHAN_PT.send(rx_rsl);
 		}
 

-- 
To view, visit https://gerrit.osmocom.org/7809
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcfb1897dd00df1839cf1a0182a5a030bf71c0cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list