[MERGED] osmo-ttcn3-hacks[master]: msc: Fix ti_flag mistake in f_mt_sms()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Apr 14 19:37:35 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: msc: Fix ti_flag mistake in f_mt_sms()
......................................................................


msc: Fix ti_flag mistake in f_mt_sms()

The L3 transaction-id in MT-SMS is allocated in the MSC, so any
messages we expect from the MSC must carry c_TIF_ORIG.

Change-Id: I6ea977a7662fdfc9c504f13ac5632ac20a04f522
---
M msc/BSC_ConnectionHandler.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index 733daab..8c9b723 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -880,7 +880,7 @@
 	BSSAP.send(ts_PDU_DTAP_MO(l3_mo, spars.dlci, true));
 
 	/* expect CP-ACK for CP-DATA(RP-ACK) just sent */
-	l3_mt := tr_ML3_MT_SMS(spars.tid, c_TIF_REPL, tr_CP_ACK_MT);
+	l3_mt := tr_ML3_MT_SMS(spars.tid, c_TIF_ORIG, tr_CP_ACK_MT);
 	BSSAP.receive(tr_PDU_DTAP_MT(l3_mt, spars.dlci));
 
 	deactivate(d);

-- 
To view, visit https://gerrit.osmocom.org/7797
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ea977a7662fdfc9c504f13ac5632ac20a04f522
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list