This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7772/1/src/libbsc/acc_ramp.c File src/libbsc/acc_ramp.c: Line 267: if (trx0 && trx_is_usable(trx0) && trx0->mo.nm_state.administrative == NM_STATE_UNLOCKED) { > I know that we are then enabling ramping when we receive the event to becom At present trx_is_usable() ignores the administrative state entirely, because the nm_is_running() function does not look at it. So currently we need both checks here. Maybe this should be changed, but changing a widely used function like trx_is_usable() is out of scope for this patch set. -- To view, visit https://gerrit.osmocom.org/7772 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I054829a936f0aa1e3fa34fad6466a1cd6150e307 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-HasComments: Yes