osmo-ttcn3-hacks[master]: */regen_makefile.sh: drop multiple naming of main ttcn file

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 12 09:15:04 UTC 2018


Patch Set 2: Code-Review-1

> Is there any reason why the main file should be listed first?
 > Couldn't see any adverse effects in running the BSC tests without
 > that.

At least when I started the TTCN-3 developments, there was.  This is why I implemented the regen_makefile the way they are.  It might not be required with the runtime that we currently use, but there are TITAN configurations that require it.  Probably when you're linking one executable and not just building all the .so files.  The change from one executable to dozens of .so files was done as I believe the junit xml plugin needs it.

As this is purely cosmetic and likely to cause breakage should we ever change this again, I'm against this change.

-- 
To view, visit https://gerrit.osmocom.org/7771
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94f37d64198ce2e36c5cd8892ccd33987e1fba32
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list